fix bug - #3118
Open
Anarchid wants to merge 1 commit into
Open
Conversation
Replace the weaker IsSafePath check with SafeWritePath for io.open, os.remove/os.rename, and enable gating for VFS.Include/LoadFile/ CompressFolder and Spring.ExtractModArchiveFile. Fold the springsettings.cfg/springrc blocking into SafeWritePath itself, since the config file can redirect the write-dir and defeat all other checks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sprunk
reviewed
Jul 20, 2026
Comment on lines
+322
to
+323
| if (!LuaIO::SafeWritePath(fileName)) | ||
| luaL_error(L, "[LuaVFS::%s] invalid access: %s", __func__, fileName.c_str()); |
Collaborator
There was a problem hiding this comment.
why? this is a read path and not a write path
| // if (!LuaIO::IsSimplePath(filename)) return 0; | ||
| // keep searches within the data directories | ||
| if (!LuaIO::SafeWritePath(filename)) | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
why does this one not do luaL_error like all the others? also this is a read path too
Comment on lines
-103
to
+87
| if (!IsSafePath(path)) { | ||
| if (!SafeWritePath(path)) { |
Collaborator
There was a problem hiding this comment.
this should probably depend on mode str. if r then check safe read path, if wat check safe write path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge plz 🙏
🤖 Generated with Claude Code